Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rahul] | Fix. Host Extraction Logic To Handle original_url Safely #30

Merged
merged 3 commits into from
Oct 16, 2024
Merged

[Rahul] | Fix. Host Extraction Logic To Handle original_url Safely #30

merged 3 commits into from
Oct 16, 2024

Conversation

rahu1ramesh
Copy link
Contributor

The PR aims to replace the unsafe request.origin.match with request.original_url.match and added conditional check to avoid exceptions when origin is unavailable.

bodhish
bodhish reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach may not work when we are running the plugin on a different domain.
(Example plugin added to care.ohc.network and medispeak backend)

image

We want to identify the origin in this case instead of the orginal_url

@bodhish bodhish merged commit 8b1bb6c into medispeak:main Oct 16, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish bodhish left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahu1ramesh @bodhish